[win] Adding experimental preference to enable update on runtime behavior by ShahzaibIbrahim · Pull Request #2461 · eclipse-platform/eclipse.platform.ui

ShahzaibIbrahim · 2024-10-29T13:27:22Z

In the UI Preferences -> General -> Appearance, there is a new HiDPI setting that could be checked to enable the monitor-specific scaling of the UI. This check will also enable Edge browser by default. This is an experimental feature to test the multi-monitor HiDPI support before it is actually released and set by default. For now, this preference is disabled by default.

Note: This preference check is only available in Windows

When changing the preference, the dialog will appear to prompt the restart.

laeubi · 2024-10-29T13:30:17Z

As we have ways to know the platform, maybe only show it when running on windows?

Also either make PerMonitorV2 a link to some documentation or remove implementation details from the description.

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

ShahzaibIbrahim · 2024-10-29T13:35:02Z

As we have ways to know the platform, maybe only show it when running on windows?

@laeubi Forgot to mention but yes, we are only showing it in Windows. I have updated the description.

laeubi · 2024-10-29T13:41:05Z

If it is only shown on windows, then I don't think it needs to be mentioned as a "Windows only" in the text.

BeckerWdf · 2024-10-29T14:00:43Z

Also either make PerMonitorV2 a link to some documentation or remove implementation details from the description.

One could also add such details into the documentation page for this preference page.

ShahzaibIbrahim · 2024-10-29T14:05:53Z

@BeckerWdf @laeubi for now I have removed implementation details from the description. I have asked if we have documentation page for this right now. If yes, then I will link it.

github-actions · 2024-10-29T15:03:46Z

Test Results

1 821 files ±0 1 821 suites ±0 1h 43m 42s ⏱️ - 10m 43s
7 724 tests ±0 7 495 ✅ ±0 228 💤 ±0 1 ❌ ±0
24 333 runs ±0 23 585 ✅ ±0 747 💤 ±0 1 ❌ ±0

For more details on these failures, see this check.

Results for commit a2bbf11. ± Comparison against base commit 83c128c.

♻️ This comment has been updated with latest results.

fedejeanne

It works pretty well, I only have some minor comments about naming/typos and one important detail about preserving the selected browser when the new preference is set to false.

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties

My changes have been applied. Rebasing.

HeikoKlare

Great to finally have a proper preference for enabling the enhanced HiDPI support on Windows, thanks!

Still, in the current state, this PR introduces a regression and needs some revision regarding design and naming. See my detailed comments.

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IWorkbenchPreferenceConstants.java

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

HeikoKlare

Regarding functionality, this looks good now (except for the case that the options do not show up anymore because of a faulty conditions).

Some minor code style comments are remaining.

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

In the UI Preferences -> General -> Appearance, there is a new HiDPI setting that could be checked to enable the monitor-specific scaling of the UI. This check will also enable Edge browser by default. This is an experimental feature to test the multi-monitor HiDPI support before it is actually released and set by default. For now, this preference is disabled by default.

HeikoKlare

From my side, this also looks good now. Thank you!

HeikoKlare · 2024-10-31T17:10:51Z

Failing test is unrelated/already documented: #370

Issue: vi-eclipse/Eclipse-Platform#134 PR: eclipse-platform/eclipse.platform.ui#2461

eclipse-platform/eclipse.platform.ui#2461

BeckerWdf reviewed Oct 29, 2024

View reviewed changes

...org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java Outdated Show resolved Hide resolved

ShahzaibIbrahim linked an issue Oct 29, 2024 that may be closed by this pull request

Add experimental preference to enable update on runtime behavior vi-eclipse/Eclipse-Platform#134

Closed

BeckerWdf approved these changes Oct 29, 2024

View reviewed changes

fedejeanne previously requested changes Oct 30, 2024

View reviewed changes

ShahzaibIbrahim force-pushed the master-134 branch 2 times, most recently from ffccae6 to a05574d Compare October 30, 2024 14:56

fedejeanne force-pushed the master-134 branch from a05574d to 6783cfb Compare October 31, 2024 05:57

fedejeanne approved these changes Oct 31, 2024

View reviewed changes

HeikoKlare requested changes Oct 31, 2024

View reviewed changes

ShahzaibIbrahim force-pushed the master-134 branch 2 times, most recently from c641c89 to 351988b Compare October 31, 2024 13:10

HeikoKlare reviewed Oct 31, 2024

View reviewed changes

ShahzaibIbrahim force-pushed the master-134 branch from 351988b to eacac43 Compare October 31, 2024 15:40

HeikoKlare force-pushed the master-134 branch from eacac43 to 95b8699 Compare October 31, 2024 16:05

HeikoKlare changed the title ~~Adding experimental preference to enable update on runtime behavior~~ [win] Adding experimental preference to enable update on runtime behavior Oct 31, 2024

HeikoKlare force-pushed the master-134 branch from 95b8699 to a2bbf11 Compare October 31, 2024 16:06

HeikoKlare approved these changes Oct 31, 2024

View reviewed changes

HeikoKlare merged commit c5928bb into eclipse-platform:master Oct 31, 2024

HeikoKlare mentioned this pull request Nov 1, 2024

Correct bundle version after changes in MultiPageEditorPart #2476

Merged

HeikoKlare added the noteworthy Noteworthy feature label Nov 1, 2024

ShahzaibIbrahim mentioned this pull request Nov 4, 2024

Added N&N for experimental HiDpi setting eclipse-platform/www.eclipse.org-eclipse#242

Closed

ShahzaibIbrahim added a commit to ShahzaibIbrahim/www.eclipse.org-eclipse that referenced this pull request Nov 4, 2024

Added N&N for experimental HiDpi setting

b388d4c

Issue: vi-eclipse/Eclipse-Platform#134 PR: eclipse-platform/eclipse.platform.ui#2461

HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024

Added N&N for monitor-specific UI rescaling on Windows

45f63e9

eclipse-platform/eclipse.platform.ui#2461

HeikoKlare mentioned this pull request Nov 5, 2024

Add N&N for monitor-specific UI rescaling and SWT API enhancements on Windows eclipse-platform/www.eclipse.org-eclipse#243

Merged

HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024

Added N&N for monitor-specific UI rescaling on Windows

bbf056b

eclipse-platform/eclipse.platform.ui#2461

HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024

Added N&N for monitor-specific UI rescaling on Windows

d72825b

eclipse-platform/eclipse.platform.ui#2461

HeikoKlare pushed a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this pull request Nov 6, 2024

Added N&N for monitor-specific UI rescaling on Windows

415b202

eclipse-platform/eclipse.platform.ui#2461

Bananeweizen mentioned this pull request Dec 16, 2024

StackOverflow in CommitTable.layout() with new experimental resolution scaling preference eclipse-egit/egit#69

Open

Bananeweizen mentioned this pull request Jan 19, 2025

experimental rescaling option leads to application blocked #2734

Closed

Conversation

ShahzaibIbrahim commented Oct 29, 2024 • edited by HeikoKlare Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laeubi commented Oct 29, 2024

Uh oh!

Uh oh!

ShahzaibIbrahim commented Oct 29, 2024

Uh oh!

laeubi commented Oct 29, 2024

Uh oh!

BeckerWdf commented Oct 29, 2024

Uh oh!

ShahzaibIbrahim commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

fedejeanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HeikoKlare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HeikoKlare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HeikoKlare left a comment

Choose a reason for hiding this comment

Uh oh!

HeikoKlare commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShahzaibIbrahim commented Oct 29, 2024 •

edited by HeikoKlare

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading